Skip to content

Commit 31c3b0c

Browse files
committed
messages: open web links in full web browser
In [1], all hyperlinks within `MessagesNode` switched to using activity.openUrlInChromeCustomTab() instead of with `openUrlInExternalApp()`. This causes web links in chat messages to open in an "in-app" Chrome Custom Tab [2] instead of the user's configured "full" web browser. This is a UX nuisance. Open web links in a full browser instead. Closes element-hq#3885 [3]. [1]: 5baefd4 (Identity change: handle click on "learn more") [2]: https://developer.chrome.com/docs/android/custom-tabs/guide-get-started#opening_a_custom_tab [3]: element-hq#3885
1 parent 3668e86 commit 31c3b0c

File tree

1 file changed

+4
-1
lines changed
  • features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl

1 file changed

+4
-1
lines changed

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNode.kt

+4-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import io.element.android.features.messages.impl.timeline.di.LocalTimelineItemPr
4040
import io.element.android.features.messages.impl.timeline.di.TimelineItemPresenterFactories
4141
import io.element.android.features.messages.impl.timeline.model.TimelineItem
4242
import io.element.android.libraries.androidutils.browser.openUrlInChromeCustomTab
43+
import io.element.android.libraries.androidutils.system.openUrlInExternalApp
4344
import io.element.android.libraries.androidutils.system.toast
4445
import io.element.android.libraries.architecture.NodeInputs
4546
import io.element.android.libraries.architecture.inputs
@@ -148,7 +149,9 @@ class MessagesNode @AssistedInject constructor(
148149
is PermalinkData.RoomLink -> {
149150
handleRoomLinkClick(activity, permalink, eventSink)
150151
}
151-
is PermalinkData.FallbackLink,
152+
is PermalinkData.FallbackLink -> {
153+
activity.openUrlInExternalApp(url)
154+
}
152155
is PermalinkData.RoomEmailInviteLink -> {
153156
activity.openUrlInChromeCustomTab(null, darkTheme, url)
154157
}

0 commit comments

Comments
 (0)