Allow dismissing 'Key storage out of sync' temporarily #31455
+591
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cross-signing keys are missing both locally and in 4S, show a new toast saying that identity needs resetting, rather than saying that the device needs to be verified.
- move enum from SetupEncryptionToast to DeviceListener - DeviceListener has public method to get device state - DeviceListener emits events to update device state
brings RecoveryPanelOutOfSync in line with SetupEncryptionToast behaviour
rather than using its own logic
andybalaam
added
the
T-Feature
richvdh
reviewed
Dec 11, 2025
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
My suspicion is that, without changes to DeviceListener, this will pop up again next time there is any change to devices, etc
Member
Author
I'm sure you're right, thanks. I'll check this. |
Member
Author
It turns out this change does actually update state, because it calls So I think this change actually does what it should :-) |
andybalaam
force-pushed
the
andybalaam/allow-dismiss-key-storage-out-of-sync
branch
from
c5d1d58 to
6e51ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Dismiss" button to the "Key storage out of sync" toast, which closes the dialog for this session only.
Fixes #30959
Based on #31367 - wait for that to merge first.