MVVM WidgetContextMenu component to shared component #31190
+1,117
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
MarcWadai
changed the title
MarcWadai
changed the title
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
7808a0f to
8b05a82
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
8b05a82 to
6889a1f
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
6889a1f to
7d6a223
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
7d6a223 to
a01c666
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
31dce41 to
c493098
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
5b6a8ea to
2ec4900
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
2ec4900 to
a4aff02
Compare
MarcWadai
force-pushed
the
29633-widget-contextmenu
branch
from
c0a03b2 to
6ac3193
Compare
Collaborator
Author
Now only the shared component visual test failed with 0.3081597222222222% difference in the snapshots... Do i need to install something specific on my local to match what the CI is doing ? |
Member
|
I haven't touched the shared-components stack yet so not sure, best asking in one of the dev rooms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue #29633
This PR will be needed for WidgetCard to be moved as a shared-component. In PR
Changes