Draft
Conversation
Tracing and tracing subscriber are the idiomatic way to instrument Rust programs with logs.
The thiserror crate will allow us to better handle errors as they are emitted from various parts of the program. For now, I propose that we just default to propagating all errors up to the level of `ElementaryCliError`; but as the runtime gets more nuanced, we can decide how to better handle non-critical errors.
If either the event poller or the TCP listener thread returns an error, we propagate it up to the CLI.
`--list-devices` lists all devics that are discoverable via cpal. If a device has neither input nor output, then we don't list it.
As a development environment; but also potentially for CI down the line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.