Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow skip-check label on PRs to main #309

Closed
wants to merge 1 commit into from
Closed

fix: allow skip-check label on PRs to main #309

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Now that Dependabot is allowed on release branches we should allow skipping the backport check on all related PRs

See electron/electron#43827

@codebytere codebytere requested a review from a team as a code owner September 23, 2024 09:06
MarshallOfSound
MarshallOfSound reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this what no-backport does already? i.e. no-backport works for main, skip works for non-main?

@codebytere
Copy link
Member Author

yep, im happy to close here - this was motivated by the failing checks i saw on the dependabot PRs earlier that were adding skip to main PRs

@codebytere codebytere closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @ckerr @MarshallOfSound