Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove needs-manual label from original PR #306

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

codebytere
Copy link
Member

Closes #297.

Ensures that when a backport PR is opened manually, and then target labels are put on that, that the resultant bookkeeping is performed correctly.

  1. PR 123 is opened and set to target branches x, y, and z
  2. PR 123 is reviewed and merged
  3. Trop opens a backport to z, but can't backport to x and y
  4. A maintainer opens a manual backport to y and adds a target to x, which shows it will be clean
  5. When the manual backport to y is merged, trop opens a backport from y to x
  6. When the auto-backport to x is merged, the original PR 123 should have its label updated to reflect that and the target label should be removed from the PR to y.

@codebytere codebytere requested a review from a team as a code owner September 10, 2024 08:22
@codebytere codebytere force-pushed the fix-needs-manual-og-pr branch from 793b592 to 3562d00 Compare September 10, 2024 08:24
src/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: David Sanders <[email protected]>
@codebytere codebytere merged commit f65e754 into main Sep 11, 2024
3 checks passed
@codebytere codebytere deleted the fix-needs-manual-og-pr branch September 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubling up status labels for transitive backports
3 participants