-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add team_reviewers to requestReviewers #276
fix: add team_reviewers to requestReviewers #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing some search on GitHub to confirm, I think this does need to ensure that only the team slug, (e.g. wg-releases
, not electron/wg-releases
) gets used. Examples I found:
- https://github.com/ampproject/cdn-configuration/blob/5f529809a21a875a9a474202b08f06136d481c6a/scripts/promote-job.ts#L165
- https://github.com/leftxs/cloudflare-docs/blob/10574f1ba0192c6f3ba849682a8c5152063ffefb/.github/actions/assign-pr/index.ts#L115-L116
It would be nice to handle both cases since then we don't have to bug anyone about changing it if the current format is the prefixed version.
Nice call! New changes should handle both the case that we have electron/wg-releases or if in the future we change it to just wg-releases. |
8ddf495
to
9e4abd7
Compare
This PR:
DEFAULT_BACKPORT_REVIEW_TEAM
to missing team_reviewers param in octokit: See API doc