fix: trafficLightPosition incorrect with customButtonsOnHover
#48538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
electron-cation
bot
added
new-pr 🌱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48463.
Fixes an issue where
trafficLightPositionwould not be correctly applied when usingtitleBarStyle: 'customButtonsOnHover'. On macOS 26, toggling the hidden state of the standard window buttons cancause AppKit to re-layout the title bar container and reset its frame, which loses the custom margin adjustments.
To fix this re-apply the calculated geometry after visibility changes to keep the buttons at the specified margin
instead of snapping back to the default until the next manual resize.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
trafficLightPositionwould not be correctly applied when usingtitleBarStyle: 'customButtonsOnHover'on macOS 26.