feat: read process fields (#14)#17
Merged
MarshallOfSound merged 3 commits intoelectron:masterfrom Dec 1, 2019
Merged
Conversation
MarshallOfSound
requested changes
Dec 1, 2019
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Can you push again so that CI runs, I just enabled it for forked PRs
MarshallOfSound
requested changes
Dec 1, 2019
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Looks good to me, can you extract this to the markdown-helpers file and add a set of tests for it. (Process tags not present, just renderer, just main, both, etc.)
Once we've got tests I'll land and release this 👍
* add ProcessBlock type * add markdown-helper.findProcess * add markdown-helper.findProcess tests
MarshallOfSound
approved these changes
Dec 1, 2019
MarshallOfSound
changed the title
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thanks! |
Contributor
Author
|
Seriously, why isn't this used for the electron builds? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read process fields correctly.