Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application ID name #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ These are all options for the CLI:
-i, --input-directory <path> Directory containing your application
-o, --output-directory <path> Output directory for the appx
-p, --package-version <version> Version of the app package
-n, --package-name <name> Name of the app package
-n, --package-name <name> Name of the app package (example: 12345MyCompany.Ghost)
--package-display-name <displayName> Display name of the package
--package-description <description> Description of the package
--package-background-color <color> Background color for the app icon (example: #464646)
-e, --package-executable <executablePath> Path to the package executable
--application-id <applicationId> Application id (example: Ghost)
-a, --assets <assetsPath> Path to the visual assets for the appx
-m, --manifest <manifestPath> Path to a manifest, if you want to be overwritten
-d, --deploy <true|false> Should the app be deployed after creation?
--identity-name <name> Name for identity
--publisher <publisher> Publisher to use (example: CN=developmentca)
--publisher-display-name <publisherDisplayName> Publisher display name to use
--make-pri <true|false> Use makepri.exe (you don't need to unless you know you do)
Expand All @@ -101,10 +101,11 @@ convertToWindowsStore({
inputDirectory: 'C:\\input\\',
outputDirectory: 'C:\\output\\',
packageVersion: '1.0.0.0',
packageName: 'Ghost',
packageName: '12345MyCompany.Ghost',
packageDisplayName: 'Ghost Desktop',
packageDescription: 'Ghost for Desktops',
packageExecutable: 'app/Ghost.exe',
applicationId: 'Ghost',
assets: 'C:\\assets\\',
manifest: 'C:\\AppXManifest.xml',
deploy: false,
Expand Down
5 changes: 3 additions & 2 deletions bin/windowsstore.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ program
.option('-i, --input-directory <path>', 'Directory containing your application')
.option('-o, --output-directory <path>', 'Output directory for the appx')
.option('-p, --package-version <version>', 'Version of the app package')
.option('-n, --package-name <name>', 'Name of the app package')
.option('--identity-name <name>', 'Name for identity')
.option('-n, --package-name <name>', 'Name of the app package (example: 12345MyCompany.Ghost)')
.option('--identity-name <name>', 'Name for identity (deprecated; use --package-name)')
.option('--package-display-name <displayName>', 'Dispay name of the package')
.option('--package-description <description>', 'Description of the package')
.option('--package-background-color <color>', 'Background color for the app icon (example: #464646)')
.option('--application-id <applicationId>', 'Application id (example: Ghost)')
.option('-e, --package-executable <executablePath>', 'Path to the package executable')
.option('-a, --assets <assetsPath>', 'Path to the visual assets for the appx')
.option('-m, --manifest <manifestPath>', 'Path to a manifest, if you want to overwrite the default one')
Expand Down
2 changes: 1 addition & 1 deletion lib/convert.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function convertWithFileCopy (program) {
result = result.replace(/\${publisherDisplayName}/g, program.publisherDisplayName || 'Reserved')
result = result.replace(/\${identityName}/g, program.identityName || program.packageName)
result = result.replace(/\${packageVersion}/g, program.packageVersion)
result = result.replace(/\${packageName}/g, program.packageName)
result = result.replace(/\${applicationId}/g, program.applicationId || program.packageName)
result = result.replace(/\${packageExecutable}/g, executable)
result = result.replace(/\${packageDisplayName}/g, program.packageDisplayName || program.packageName)
result = result.replace(/\${packageDescription}/g, program.packageDescription || program.packageName)
Expand Down
10 changes: 8 additions & 2 deletions lib/params.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,16 @@ module.exports = function (program) {
},
when: () => (!program.outputDirectory)
},
{
name: 'applicationId',
type: 'input',
message: "Please enter your app's application id (Example: Ghost): ",
when: () => (!program.applicationId)
},
{
name: 'packageName',
type: 'input',
message: "Please enter your app's package name (name of your exe - without '.exe'): ",
message: "Please enter your app's package name (Example: 12345MyCompany.Ghost): ",
when: () => (!program.packageName)
},
{
Expand All @@ -76,7 +82,7 @@ module.exports = function (program) {
inquirer.prompt(questions)
.then((answers) => {
if (!program.packageExecutable && program.containerVirtualization) {
program.packageExecutable = `C:\\Users\\ContainerAdministrator\\AppData\\Roaming\\e\\${program.packageName}.exe`
program.packageExecutable = `C:\\Users\\ContainerAdministrator\\AppData\\Roaming\\e\\${program.applicationId}.exe`
}

Object.assign(program, answers)
Expand Down
2 changes: 1 addition & 1 deletion template/appxmanifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<rescap:Capability Name="runFullTrust"/>
</Capabilities>
<Applications>
<Application Id="${packageName}" Executable="${packageExecutable}" EntryPoint="Windows.FullTrustApplication">
<Application Id="${applicationId}" Executable="${packageExecutable}" EntryPoint="Windows.FullTrustApplication">
<uap:VisualElements
BackgroundColor="${packageBackgroundColor}"
DisplayName="${packageDisplayName}"
Expand Down