Add multi-directory support #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An initial start to add directory support, looking to get help/advice from community to make code more robust. Added capability to prefix key with directory for get, set, has, remove (i.e. "testfolder/foo" will get, set, has, or remove foo under the testfolder directory). Also extended functions getAll, keys, clear* to allow optional directory parameter (i.e. "testfolder" will getAll, keys or clear* under the testfolder directory. getMany is tricky and needs some work. *Currently clear removes the directory passed to function. **All current test cases pass with exception of utils test function since directory is different
… few other cleanup changes.
|
Hi @stromboul , Thanks for this! The PR has conflicts, and its bringing in unrelated changed, which can be solved by rebasing You can take the old PR, do Let me know if I can help with anything! |
… directory parameter - Reworked a bit how those 2 functions work so they correctly get data from a different folder than the 'current'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up branch from a fork of PR #51 branch.
(not sure if this was the correct way to continue someone else's work...) (and also this is my first PR on github, so if I've done something unexpected or wrong, please point me in the correct direction and I'll try to fix things)