feat: Update squirrel windows to 2.0.1 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to upload all items from the |
|
From the windows-installer source code, it appears that all of these are used. We are currently using windows-installer directly, so I suggest uploading all of them. |
|
@mmaietta Can you help merge this in? |
|
@beyondkmp how do we perform a release of this to Github tagged release (post-merge) for this updated toolset? Maybe we can chat further via discord |
|
@beyondkmp / @mmaietta appreciate your effort thus far, any progress on this behind the scenes? Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files were copied from the vendor folder in this archive: https://github.com/electron/windows-installer/archive/refs/tags/v5.4.0.zip.