fix: reset agentName on session_start so /new generates a fresh name - #21
Merged
Conversation
Without this reset, the module-level agentName variable retained the previous session's name across /new because the extension module is not reloaded. The 'if (!agentName)' guard after the restore loop never triggered, so generateName() was never called. Co-authored-by: gentle-newt-20 <gentle-newt-20@pi-agent.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After
/new, the agent keeps the same name from the previous session.Root cause
agentNameis a module-level variable that persists when/newreuses the same pi process and extension module. After the restore loop finds nothing in the new (empty) session file,if (!agentName)isfalsebecause the old name is still set — sogenerateName()is never called.Fix
Reset
agentName = ""at the top ofsession_start, alongside theshuttingDownreset added in #20. Both are needed so/newproduces a fully fresh session identity.Tested
/new, agent name changes (e.g.shadow-raven-24→silver-quail-9)— gentle-newt-20