added config_file_path param #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I understand your PR, this new parameter is another configdir, with the file name. |
|
Here is the completion of what I said : PR #54 |
oloc
pushed a commit
to oloc/puppet-logstashforwarder
that referenced
this pull request
Jul 9, 2015
|
Sure that works too. I briefly looked over your PR and it looks good but I didn't do any testing. I'll close this in favor of #54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the need to specify the main config logstash forwarder config file path, so I added
$config_file_path. It defaults to the value that was previously hardcoded which is/etc/logstash-forwarder.conf. This may be useful for anyone who needs to override it for whatever reason.