Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove links to master #4808

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[DOCS] Remove links to master #4808

merged 1 commit into from
Jan 30, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 30, 2025

Description

Relates to elastic/docs#3160

This PR fixes the following broken link:

INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/serverless/current/observability-case-settings.html contains broken links to:
--
  | INFO:build_docs:   - en/kibana/master/thehive-action-type.html

I think this PR only needs to be merged if we assume that we'll want to stop the main branch of the Kibana Guide before we stop building the only branch of the Serverless Guide.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@lcawl lcawl added the backport-skip Skip notification from the automated backport with mergify label Jan 30, 2025
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@lcawl lcawl marked this pull request as ready for review January 30, 2025 07:52
@lcawl lcawl requested a review from a team as a code owner January 30, 2025 07:52
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 8ea3a09 into elastic:main Jan 30, 2025
12 of 13 checks passed
@lcawl lcawl deleted the doc-links branch January 30, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants