Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix stack trace syntax highlight #205187

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Dec 27, 2024

fixes: #204957

Summary

This PR fixes the stack trace syntax highlight

image

@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 backport:version Backport to applied version labels v8.17.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 27, 2024
@crespocarlos crespocarlos force-pushed the 204957-stack-track-syntax-highlight-fix branch from bc72954 to dd3726e Compare December 27, 2024 11:23
@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos marked this pull request as ready for review December 27, 2024 16:56
@crespocarlos crespocarlos requested review from a team as code owners December 27, 2024 16:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@crespocarlos crespocarlos added backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Dec 30, 2024
@crespocarlos crespocarlos enabled auto-merge (squash) December 30, 2024 15:00
@crespocarlos crespocarlos merged commit a78f616 into elastic:main Dec 30, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12548775726

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 30, 2024
fixes: [elastic#204957](elastic#204957)

## Summary

This PR fixes the stack trace syntax highlight

<img width="1452" alt="image"
src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a78f616)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 30, 2024
fixes: [elastic#204957](elastic#204957)

## Summary

This PR fixes the stack trace syntax highlight

<img width="1452" alt="image"
src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a78f616)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16 Backport failed because of merge conflicts
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 205187

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 30, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Fix stack trace syntax highlight
(#205187)](#205187)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T15:48:38Z","message":"[APM]
Fix stack trace syntax highlight (#205187)\n\nfixes:
[#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n##
Summary\r\n\r\nThis PR fixes the stack trace syntax
highlight\r\n\r\n<img width=\"1452\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services"],"title":"[APM]
Fix stack trace syntax
highlight","number":205187,"url":"https://github.com/elastic/kibana/pull/205187","mergeCommit":{"message":"[APM]
Fix stack trace syntax highlight (#205187)\n\nfixes:
[#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n##
Summary\r\n\r\nThis PR fixes the stack trace syntax
highlight\r\n\r\n<img width=\"1452\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205187","number":205187,"mergeCommit":{"message":"[APM]
Fix stack trace syntax highlight (#205187)\n\nfixes:
[#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n##
Summary\r\n\r\nThis PR fixes the stack trace syntax
highlight\r\n\r\n<img width=\"1452\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 30, 2024
# Backport

This will backport the following commits from `main` to `8.17`:
- [[APM] Fix stack trace syntax highlight
(#205187)](#205187)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T15:48:38Z","message":"[APM]
Fix stack trace syntax highlight (#205187)\n\nfixes:
[#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n##
Summary\r\n\r\nThis PR fixes the stack trace syntax
highlight\r\n\r\n<img width=\"1452\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services"],"title":"[APM]
Fix stack trace syntax
highlight","number":205187,"url":"https://github.com/elastic/kibana/pull/205187","mergeCommit":{"message":"[APM]
Fix stack trace syntax highlight (#205187)\n\nfixes:
[#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n##
Summary\r\n\r\nThis PR fixes the stack trace syntax
highlight\r\n\r\n<img width=\"1452\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205187","number":205187,"mergeCommit":{"message":"[APM]
Fix stack trace syntax highlight (#205187)\n\nfixes:
[#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n##
Summary\r\n\r\nThis PR fixes the stack trace syntax
highlight\r\n\r\n<img width=\"1452\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Error details missing language syntax highlight
5 participants