Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX] Span flyout show Otel plaintext stack trace #172489

Merged
merged 9 commits into from
Dec 18, 2023
Merged

[ObsUX] Span flyout show Otel plaintext stack trace #172489

merged 9 commits into from
Dec 18, 2023

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Dec 4, 2023 •
edited
Loading

closes #169769

Summary

This PR adapts the Stack Trace tab to also display plaintext stacktraces generated by Otel agents

image image image

How to test

The easiest way to test:

node x-pack/plugins/apm/scripts/test/e2e.js --spec span_stacktrace.cy.ts

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos changed the title 169769 plaintext stacktrace [ObsUX] Span flyout show Otel plaintext stack trace Dec 5, 2023
@crespocarlos crespocarlos added apm:transaction-metrics APM UI - Transaction Metrics Work v8.12.0 Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 5, 2023
@crespocarlos crespocarlos marked this pull request as ready for review December 5, 2023 14:08
@crespocarlos crespocarlos requested review from a team as code owners December 5, 2023 14:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

mykolaharmash
mykolaharmash reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨ Generating test data with synthtrace looks great!

@mykolaharmash mykolaharmash self-requested a review December 13, 2023 10:06
@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB +167.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/apm-synthtrace-client 27 28 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos merged commit 4ee1b1f into elastic:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@AlexanderWert AlexanderWert Awaiting requested review from AlexanderWert

Assignees
No one assigned
Labels
apm:transaction-metrics APM UI - Transaction Metrics Work backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Display plaintext stacktrace on spans
7 participants
@crespocarlos @apmmachine @elasticmachine @kibana-ci @sorenlouv @mykolaharmash @kibanamachine