-
Notifications
You must be signed in to change notification settings - Fork 472
[statsd_input] update statsd_input package manifest.yml format_version to 3.4.0. #14577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[statsd_input] update statsd_input package manifest.yml format_version to 3.4.0. #14577
Conversation
…tions # Conflicts: # packages/statsd_input/changelog.yml # packages/statsd_input/manifest.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ishleenk17 system tests pass and it was tested using local stack by @giorgi-imerlishvili-elastic |
packages/statsd_input/manifest.yml
Outdated
description: StatsD Input Package | ||
type: input | ||
source: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it errroing out that we had to add this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked other packages with version upper than 3.0 and used those packages as example
But I think without that property it should work either, because it's not defined as required property in spec: https://github.com/elastic/package-spec/blob/v3.4.0/spec/input/manifest.spec.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishleenk17 shall source.license
be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not a mandate, we can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test |
/test |
💚 Build Succeeded
History
|
|
Package statsd_input - 0.6.0 containing this change is available at https://epr.elastic.co/package/statsd_input/0.6.0/ |
Proposed commit message
Update package statsd_input's manifest.yml format_version to 3.4.0
Update files packages/statsd_input/fields/input.yml and packages/statsd_input/manifest.yml accordingly
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Closes https://github.com/elastic/obs-integration-team/issues/387
Screenshots