Skip to content

[AWS Health] Remove linked accounts option from config #14573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[AWS Health] Remove linked accounts option from config #14573

wants to merge 4 commits into from
+6 −15

Conversation

lucian-ioan
Copy link
Contributor

@lucian-ioan lucian-ioan commented Jul 17, 2025 •
edited
Loading

Proposed commit message

Removes linked account option from config as it is not currently supported.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lucian-ioan lucian-ioan self-assigned this Jul 17, 2025
@lucian-ioan lucian-ioan requested review from a team as code owners July 17, 2025 05:59
@lucian-ioan lucian-ioan added bug Something isn't working, use only for issues Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 17, 2025
@lucian-ioan lucian-ioan requested a review from agithomas July 17, 2025 05:59
@lucian-ioan lucian-ioan requested a review from gpop63 July 17, 2025 06:01
agithomas
agithomas reviewed Jul 17, 2025
View reviewed changes
packages/aws/data_stream/awshealth/manifest.yml Outdated
show_user: false
default: true
description: When include_linked_accounts is set to true, CloudWatch metrics will be collected from both linked accounts and the monitoring account. Default is true.
# - name: include_linked_accounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add an appropriate comment on why it is commented out or remove this configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think owning_account is also related to this linked account feature, and if we remove these variables from the manifest what about the agent config that references them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @gpop63 . @lucian-ioan , kindly do an upgrade testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, pushed the changes. I'm also upgrading the integration from a previous version to this one to check that all goes well.

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 17, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @lucian-ioan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas left review comments

@gpop63 gpop63 Awaiting requested review from gpop63

At least 1 approving review is required to merge this pull request.

Assignees

@lucian-ioan lucian-ioan

Labels
bug Something isn't working, use only for issues Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS Health] Add support for the linked account
5 participants
@lucian-ioan @elasticmachine @gpop63 @agithomas @andrewkroh