-
Notifications
You must be signed in to change notification settings - Fork 471
[Netskope] Add Events v2
data stream
#14524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Currently successful CI for this PR is blocked by: elastic/package-spec#925 |
Co-authored-by: Andrew Kroh <[email protected]>
resource "aws_s3_object" "object" { | ||
bucket = aws_s3_bucket.bucket.id | ||
key = "event.csv.gz" | ||
source = "./files/event.csv.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the base64gzip function to avoid adding an opaque gzip file to the repo, which makes it hard to review changes via diffs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me use base64gzip function.
- name: event.dataset | ||
type: constant_keyword | ||
external: ecs | ||
value: netskope.event_v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue description and PR commit says the name should be events_v2
instead of event_v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#14443 also has alerts_v2
.
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "2.1.0" | |||
changes: | |||
- description: Add support for Events v2 data stream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add necessary steps to README for setting up ingestion of this new data format from Netskope side and also Elastic side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, I see you are going to first merge #14443 which takes care of docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was my plan to merge #14443 first and then i'll make changes on top of that.
auth.oauth2: | ||
client_id: {{client_id}} | ||
client_secret: {{client_secret}} | ||
tenant_id: {{tenant_id}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update README with required permissions as per #14443 (comment)
] | ||
}, | ||
"server": { | ||
"bytes": 67997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy server.*
into destination.*
.
"client": { | ||
"bytes": 3613917 | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy client.*
into source.*
/test |
💔 Build Failed
Failed CI StepsHistory
|
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots