Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elastic_agent] Add missing apm-server tail sampling monitoring metrics mappings #12568

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[elastic_agent] Add missing apm-server tail sampling monitoring metrics mappings #12568

merged 2 commits into from
Feb 3, 2025

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Feb 3, 2025 •
edited
Loading

Proposed commit message

[elastic_agent] Add missing apm-server tail sampling monitoring metrics mappings

Tail-based sampling monitoring metrics were missed in the bugfix in #10414

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@carsonip carsonip changed the title [elastic_agent] Add missing apm-server TBS monitoring metrics mappings [elastic_agent] Add missing apm-server tail sampling monitoring metrics mappings Feb 3, 2025
@carsonip carsonip marked this pull request as ready for review February 3, 2025 15:30
@carsonip carsonip requested a review from a team as a code owner February 3, 2025 15:30
@carsonip carsonip added bug Something isn't working, use only for issues bugfix Pull request that fixes a bug issue and removed bug Something isn't working, use only for issues labels Feb 3, 2025
@andrewkroh andrewkroh added the Integration:elastic_agent Elastic Agent label Feb 3, 2025
@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@carsonip carsonip requested review from cmacknz and leehinman February 3, 2025 18:21
@carsonip carsonip mentioned this pull request Feb 3, 2025
Closed
leehinman
leehinman approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsonip carsonip merged commit af145a1 into elastic:main Feb 3, 2025
4 of 5 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package elastic_agent - 2.0.4 containing this change is available at https://epr.elastic.co/package/elastic_agent/2.0.4/

qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@carsonip
[elastic_agent] Add missing apm-server tail sampling monitoring metri…
f59e5ec 
…cs mappings (#12568)

[elastic_agent] Add missing apm-server tail sampling monitoring metrics mappings

Tail-based sampling monitoring metrics were missed in the bugfix in #10414
jlind23 pushed a commit that referenced this pull request Feb 5, 2025
@carsonip
[elastic_agent] Add missing apm-server tail sampling monitoring metri…
c7103bb 
…cs mappings (#12568)

[elastic_agent] Add missing apm-server tail sampling monitoring metrics mappings

Tail-based sampling monitoring metrics were missed in the bugfix in #10414
@carsonip carsonip deleted the apm-server-tbs-metrics branch February 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:elastic_agent Elastic Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carsonip @elasticmachine @leehinman @andrewkroh