Skip to content

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Oct 3, 2025

This PR bumps the MacOS SDK version to 12.3 (was 10.11). This is needed because Golang 1.25 requires MacOS 12 Monterey or later.

As a pre-requisite to this PR, the MacOS 12.3 SDK was packaged locallly by following these steps and uploaded to the appropriate GCS bucket.

Resolves #662.

@ycombinator ycombinator requested a review from a team as a code owner October 3, 2025 12:06
Copy link

mergify bot commented Oct 3, 2025

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Oct 3, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 3, 2025
cmacknz
cmacknz previously approved these changes Oct 3, 2025
@ycombinator
Copy link
Contributor Author

CI is failing like so:


#8 0.312 Err:4 http://deb.debian.org/debian buster Release
--
  | #8 0.312   404  Not Found [IP: 151.101.2.132 80]
  | #8 0.324 Err:5 http://deb.debian.org/debian-security buster/updates Release
  | #8 0.324   404  Not Found [IP: 151.101.2.132 80]
  | #8 0.335 Err:6 http://deb.debian.org/debian buster-updates Release
  | #8 0.335   404  Not Found [IP: 151.101.2.132 80]

We're actually seeing similar errors on main as well: https://buildkite.com/elastic/golang-crossbuild/builds/1374#0199862d-3c4f-4dfd-afbe-ae359d943fa5/156-258.

Investigating...

@ycombinator
Copy link
Contributor Author

ARM builds are passing for all versions of Debian. x86_64 builds are passing for Debian 7, 10, 11, and 12 but failing for Debian 8 and 9 with the following error:

32.72 CMake Error at CMakeLists.txt:3 (cmake_minimum_required):
--
  | 32.72   CMake 3.13.4 or higher is required.  You are running version 3.7.2

Separately, LLVM x86_64 builds are failing for Debian 10 and 11 (but not 12) with the following errors:

> [build_llvm_apple 3/8] RUN apt-get -o Acquire::Check-Valid-Until=false update -y --no-install-recommends --allow-unauthenticated         && apt-get upgrade -y --no-install-recommends --allow-unauthenticated         && apt-get dist-upgrade -y --no-install-recommends --allow-unauthenticated         && apt-get install -y --no-install-recommends --allow-unauthenticated             build-essential             ca-certificates             curl             git             gnupg             make             file             flex             bison             cmake             patch             libssl-dev             libxml2-dev             lzma-dev             uuid-dev             binutils-multiarch             binutils-multiarch-dev             python3-venv             python3-pip             python3         && rm -rf /var/lib/apt/lists/*:
--
  | 5.938 E: Package 'bison' has no installation candidate
  | 5.938 E: Package 'cmake' has no installation candidate
  | 5.938 E: Package 'patch' has no installation candidate
  | 5.938 E: Package 'libssl-dev' has no installation candidate
  | 5.938 E: Package 'libxml2-dev' has no installation candidate
  | 5.938 E: Package 'uuid-dev' has no installation candidate
  | 5.938 E: Package 'binutils-multiarch' has no installation candidate
  | 5.938 E: Unable to locate package binutils-multiarch-dev
  | 5.938 E: Package 'python3-venv' has no installation candidate
  | 5.938 E: Package 'python3' has no installation candidate

@ycombinator ycombinator requested a review from v1v October 3, 2025 18:44
@cmacknz
Copy link
Member

cmacknz commented Oct 3, 2025

Debian 8 and 9 with the following error:

Can we just not do this version bump for those debian versions?

@v1v
Copy link
Member

v1v commented Oct 7, 2025

05:32:17 CEST | ERROR: (gcloud.storage.cp) There was a problem refreshing your current auth tokens: ('Error code invalid_grant: ID Token issued at 1759793059 is stale to sign-in.', '{"error":"invalid_grant","error_description":"ID Token issued at 1759793059 is stale to sign-in."}')

I bet the OIDC token got expired, let me find if we can setup the TTL for the token explicitly

See https://github.com/elastic/oblt-google-auth-buildkite-plugin#properties

lifetime | The time (in seconds) the OIDC token will be valid for before expiry. Must be a non-negative integer. | false | 1800


See 87e9df7 (#663)

fixes There was a problem refreshing your current auth tokens
@v1v v1v requested review from a team as code owners October 7, 2025 06:57
@elasticmachine
Copy link

💚 Build Succeeded

History

@ycombinator ycombinator requested review from cmacknz and v1v October 8, 2025 19:39
@ycombinator ycombinator merged commit a2e10bf into elastic:main Oct 9, 2025
7 checks passed
@ycombinator ycombinator deleted the bump-macos-sdk-12 branch October 9, 2025 00:12
@ycombinator
Copy link
Contributor Author

@Mergifyio backport 1.25.1.x

Copy link

mergify bot commented Oct 13, 2025

backport 1.25.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 13, 2025
Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit a2e10bf)
ycombinator added a commit that referenced this pull request Oct 13, 2025
Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS SDK needs to be bumped to version 12 for Golang 1.25.x images

5 participants