Refactor ThrottleAllocationDecider#canAllocate #136424
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
DiannaHohensee
commented
Oct 10, 2025
| } | ||
| } | ||
| if (allocation.isSimulating()) { | ||
| return allocation.decision(Decision.YES, NAME, "primary allocation is not throttled when simulating"); |
There was a problem hiding this comment.
Seemed silly to do an early return after counting primariesInRecovery, which isn't used. So I moved it up, save some cycles.
DiannaHohensee
added
>non-issue
:Distributed Coordination/Allocation
elasticsearchmachine
removed
the
needs:triage
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking around in here for ES-12942, and thought this should be better.