Skip to content

https://github.com/elastic/search-labs-elastic-co/issues/1454#446

Merged
nehasaini1608 merged 4 commits intomainfrom
1454
Apr 17, 2025
Merged

https://github.com/elastic/search-labs-elastic-co/issues/1454#446
nehasaini1608 merged 4 commits intomainfrom
1454

Conversation

@nehasaini1608
Copy link
Copy Markdown
Contributor

No description provided.

@JessicaGarson
Copy link
Copy Markdown
Contributor

Hi, @nehasaini1608,

Since the pre-commit check is failing, you may want to try the following:

python -m venv .venv
.venv/bin/pip install -qqq -r requirements-dev.txt
.venv/bin/pre-commit install

@JessicaGarson
Copy link
Copy Markdown
Contributor

Thanks, @nehasaini1608, the code runs pretty well here but I did notice a few things here:

  1. Could you add a README file here?
  2. Also I noticed some .gitignore files and .codespellignore that you may want to remove from this repo.

@nehasaini1608
Copy link
Copy Markdown
Contributor Author

@JessicaGarson Thanks for your support. I have removed both .gitignore files and .codespellignore file and updated README . This is done in branch name - 1454
Ready for your review.

@JessicaGarson
Copy link
Copy Markdown
Contributor

@nehasaini1608, I had a chance to review feel free to merge as you see fit.

@nehasaini1608 nehasaini1608 merged commit 78b9309 into main Apr 17, 2025
2 checks passed
@nehasaini1608 nehasaini1608 deleted the 1454 branch April 17, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants