Reintroduce httpclientbuilder callback #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
force-pushed
the
rest5client-expose-config
branch
from
103aa10 to
3cd37a5
Compare
swallez
reviewed
Jul 15, 2025
...nt/src/main/java/co/elastic/clients/transport/rest5_client/low_level/Rest5ClientBuilder.java
Outdated
Show resolved
Hide resolved
l-trotta
changed the title
wilkinsona
reviewed
Jul 15, 2025
Comment on lines
329
to
330
| * value that the {@link Rest5ClientBuilder} internally sets, except if RequestConfig, | ||
| * ConnectionConfig and ConnectionManager are set through this callback. |
There was a problem hiding this comment.
Would you consider lower-level call backs for these three (RequestConfig, ConnectionConfig, and ConnectionManager) so that they too can be fine-tuned without also losing their defaults?
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
* add config callback to rest5 builder * modern java, updated docs * checkstyle * more callbacks
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
* add config callback to rest5 builder * modern java, updated docs * checkstyle * more callbacks
l-trotta
added a commit
that referenced
this pull request
Jul 16, 2025
* add config callback to rest5 builder * modern java, updated docs * checkstyle * more callbacks Co-authored-by: Laura Trotta <[email protected]>
l-trotta
added a commit
that referenced
this pull request
Jul 16, 2025
* add config callback to rest5 builder * modern java, updated docs * checkstyle * more callbacks Co-authored-by: Laura Trotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing more configurations from the underlying apache http rest client