[8.19] (backport #10153) Rewrite the beats receiver log test using common tooling #10505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
* Rewrite the beats receiver log test using common tooling * Expect the outputs to be degraded * Relax checks * Fix assertion * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <[email protected]> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <[email protected]> * Apply suggestion from @ycombinator Co-authored-by: Shaunak Kashyap <[email protected]> * Switch assert to required * Fix constants --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit 71ece0d)
mergify
bot
requested review from
pchila and
ycombinator
and removed request for
a team
4 tasks
github-actions
bot
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
previously approved these changes
Oct 11, 2025
|
This pull request has not been merged yet. Could you please review and merge it @swiatekm? 🙏 |
|
@swiatekm CI failed on this backport - can you take a look? |
Testify 1.10 doesn't have this implemented.
|
The failure is actually because we have different versions of testify in 9.2 and 8.19, and I unknowingly used a feature that only exists in testify 1.11. |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @swiatekm |
swiatekm
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-enables the integration test for comparing logs between beats processes and beats receivers and rewrites it to use normal integration test tooling, making it simpler and more observable:
elastic-agent logsinstead of capturing agent output directly.Why is it important?
This test should be enabled and reliable.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog toolRelated issues
This is an automatic backport of pull request #10153 done by [Mergify](https://mergify.com).