Skip to content

[8.19] (backport #10203) Check for config processing errors in coordinator unit tests #10214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
+3 −0
Merged

[8.19] (backport #10203) Check for config processing errors in coordinator unit tests #10214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/pkg/agent/application/coordinator/coordinator_unit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,7 @@ service:
configChan <- cfgChange
coord.runLoopIteration(ctx)
assert.True(t, cfgChange.acked, "empty policy should be acknowledged")
assert.NoError(t, cfgChange.err, "config processing shouldn't report an error")
assert.True(t, updated, "empty policy should cause runtime manager update")
assert.Empty(t, components, "empty policy should produce empty component model")
assert.True(t, otelUpdated, "empty policy should cause otel manager update")
Expand Down Expand Up @@ -1057,6 +1058,7 @@ service:
configChan <- cfgChange
coord.runLoopIteration(ctx)
assert.True(t, cfgChange.acked, "Coordinator should ACK a successful policy change")
assert.NoError(t, cfgChange.err, "config processing shouldn't report an error")

// Make sure the runtime manager received the expected component update.
// An assert.Equal on the full component model doesn't play nice with
Expand Down Expand Up @@ -1121,6 +1123,7 @@ service:
configChan <- cfgChange
coord.runLoopIteration(ctx)
assert.True(t, cfgChange.acked, "Coordinator should ACK a successful policy change")
assert.NoError(t, cfgChange.err, "config processing shouldn't report an error")

// Make sure the runtime manager received the expected component update.
// An assert.Equal on the full component model doesn't play nice with
Expand Down