Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions pkg/ipc/listener_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"net"
"os/user"
"strings"
"time"

"golang.org/x/sys/windows"

Expand All @@ -35,11 +36,26 @@ func CreateListener(log *logger.Logger, address string) (net.Listener, error) {
if err != nil {
return nil, fmt.Errorf("failed to create security descriptor: %w", err)
}
lis, err := npipe.NewListener(npipe.TransformString(address), sd)
if err != nil {
return nil, fmt.Errorf("failed to create npipe listener: %w", err)

retryDuration := 5 * time.Second
backoffDelay := 200 * time.Millisecond

deadline := time.Now().Add(retryDuration)
var lastErr error

for time.Now().Before(deadline) {
lis, err := npipe.NewListener(npipe.TransformString(address), sd)
if err == nil {
return lis, nil
}

// Log and backoff before retrying
log.Warnf("failed to create npipe listener, retrying...: %v", err)
lastErr = err
time.Sleep(backoffDelay)
}
return lis, nil

return nil, fmt.Errorf("failed to create npipe listener after retries: %w", lastErr)
}

func CleanupListener(log *logger.Logger, address string) {
Expand Down
32 changes: 32 additions & 0 deletions pkg/ipc/listener_windows_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
// or more contributor license agreements. Licensed under the Elastic License 2.0;
// you may not use this file except in compliance with the Elastic License 2.0.

//go:build windows

package ipc

import (
"net/http"
"testing"

"github.com/stretchr/testify/require"

"github.com/elastic/elastic-agent-libs/logp"
)

func TestCreateListener(t *testing.T) {
name := "npipe:///testpipe"

// try creating and closing servers with same name multiple times
for range 1000 {
lis, err := CreateListener(logp.NewNopLogger(), name)
require.NoError(t, err)
require.NotNil(t, lis)
s := &http.Server{} //nolint:gosec // this is a test
go func() {
_ = s.Serve(lis)
}()
require.NoError(t, s.Close())
}
}
Loading