Skip to content

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 29, 2025

What does this PR do?

disable Windows permission inheritance

Why is it important?

It resolves OSQuery extension loading issues

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

@marc-gr marc-gr requested a review from a team as a code owner September 29, 2025 12:10
@marc-gr marc-gr added bug Something isn't working Team:Security-Windows Platform Team:Security-Windows Platform labels Sep 29, 2025
@marc-gr
Copy link
Contributor Author

marc-gr commented Sep 29, 2025

not sure where we might want to backport this one @cmacknz

Copy link
Contributor

mergify bot commented Sep 29, 2025

This pull request does not have a backport label. Could you fix it @marc-gr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@marc-gr marc-gr added the ci:extended-windows Enable the extended windows stage in the CI label Sep 29, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 29, 2025

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has the issue of not working. If a user goes all the way into the components directory (Windows will update the permissions of that directory), it will still fail to run. This is only reducing the chance that it happens and not actually fixing the issue.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

@marc-gr
Copy link
Contributor Author

marc-gr commented Sep 30, 2025

This still has the issue of not working. If a user goes all the way into the components directory (Windows will update the permissions of that directory), it will still fail to run. This is only reducing the chance that it happens and not actually fixing the issue.

as discussed I'll close this one and implement this on osquerybeat instead

@marc-gr marc-gr closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci:extended-windows Enable the extended windows stage in the CI Team:Security-Windows Platform Team:Security-Windows Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants