Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions internal/pkg/agent/application/enroll/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,18 +139,17 @@ func MergeOptionsWithMigrateAction(action *fleetapi.ActionMigrate, options Enrol
return EnrollOptions{}, fmt.Errorf("failed to decode enroll options: %w", err)
}

if len(options.ReplaceToken) == 0 {
// do not preserve ID by default
delete(configMap, "id")
options.ID = ""
}

// overwriting what's needed
if len(action.Data.Settings) > 0 {
if err := json.Unmarshal(action.Data.Settings, &configMap); err != nil {
return EnrollOptions{}, fmt.Errorf("failed to decode migrate setting: %w", err)
}
}

if _, ok := configMap["replace_token"]; !ok {
// do not preserve ID by default
delete(configMap, "id")
options.ID = ""
}

cmBytes, err := json.Marshal(configMap)
Expand Down
22 changes: 22 additions & 0 deletions internal/pkg/agent/application/enroll/options_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,28 @@ func TestMergeOptionsWithMigrateAction(t *testing.T) {
},
false,
},
{
"original id is used when replace token provided",
&fleetapi.ActionMigrate{
Data: fleetapi.ActionMigrateData{
EnrollmentToken: "token",
TargetURI: "uri",
Settings: json.RawMessage(`{"insecure": true, "replace_token": "replace-token", "tags":["a","b"]}`),
},
},
EnrollOptions{
ID: "test-id",
},
EnrollOptions{
EnrollAPIKey: "token",
ID: "test-id",
Insecure: true,
ReplaceToken: "replace-token",
Tags: []string{"a", "b"},
URL: "uri",
},
false,
},
}

for _, tc := range cases {
Expand Down
Loading