Improve logging to catch early errors on startup #10158
Merged
+125
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
|
blakerouse
added
the
backport-active-all
blakerouse
changed the title
|
ycombinator
reviewed
Sep 29, 2025
ycombinator
reviewed
Sep 29, 2025
ycombinator
reviewed
Sep 29, 2025
|
@ycombinator Thanks for the review. I implemented the requested fixes, if you can give this another review. |
💚 Build Succeeded
History
cc @blakerouse |
ycombinator
approved these changes
Oct 1, 2025
|
@Mergifyio backport 8.18 8.19 9.0 9.1 9.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba)
4 tasks
blakerouse
added a commit
that referenced
this pull request
Oct 2, 2025
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) Co-authored-by: Blake Rouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the
runsubcommand to always log any errors to the logger.Why is it important?
There where still some cases where the Elastic Agent can fail to run but the reason is not written to the log.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
None.
Related issues