-
Notifications
You must be signed in to change notification settings - Fork 193
Improve logging to catch early errors on startup #10158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
|
|
@ycombinator Thanks for the review. I implemented the requested fixes, if you can give this another review. |
💚 Build Succeeded
History
cc @blakerouse |
@Mergifyio backport 8.18 8.19 9.0 9.1 9.2 |
✅ Backports have been created
|
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) # Conflicts: # internal/pkg/agent/cmd/run.go
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba)
* Update run command to have a critical section to ensure errors are always logged. * Add changelog. * Cleanup from code review. (cherry picked from commit 18beeba) Co-authored-by: Blake Rouse <[email protected]>
What does this PR do?
Updates the
run
subcommand to always log any errors to the logger.Why is it important?
There where still some cases where the Elastic Agent can fail to run but the reason is not written to the log.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
None.
Related issues