-
Notifications
You must be signed in to change notification settings - Fork 193
dev-tools: add profiling special case for edot #10143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#9888 added profiling as an receiver to EDOT. Fix tooling to add this receiver to autogenerated list of components for EDOT. Signed-off-by: Florian Lehner <[email protected]>
This pull request does not have a backport label. Could you fix it @florianl? 🙏
|
``` Error: dev-tools/mage/otel/deps.go:52:3: QF1003: could use tagged switch on dependency.ComponentType (staticcheck) if dependency.ComponentType == "connector" { ^ 1 issues: * staticcheck: 1 ``` Signed-off-by: Florian Lehner <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
6de7aa6
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR LGTM.
However, I noticed that in #9888 where the profilingreceiver was added, that it's only available on Linux. I wonder if we should add a field to the otelDependency
struct to capture which OSes components are available on (defaulting to all OSes, of course). That way we could mention the OS support for each component in the OTel README. This would be done as a follow up PR.
|
💚 Build Succeeded
History
cc @florianl |
What does this PR do?
#9888 added profiling as an receiver to EDOT. Fix tooling to add this receiver to autogenerated list of components for EDOT.
Why is it important?
Checklist
./changelog/fragments
using the changelog tool