Skip to content

Conversation

florianl
Copy link
Member

What does this PR do?

#9888 added profiling as an receiver to EDOT. Fix tooling to add this receiver to autogenerated list of components for EDOT.

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

#9888 added profiling as an receiver to EDOT. Fix tooling to add this receiver to autogenerated list of components for EDOT.

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl requested a review from a team as a code owner September 25, 2025 08:37
@florianl florianl added the bug Something isn't working label Sep 25, 2025
@florianl florianl requested a review from straistaru September 25, 2025 08:37
Copy link
Contributor

mergify bot commented Sep 25, 2025

This pull request does not have a backport label. Could you fix it @florianl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

```
  Error: dev-tools/mage/otel/deps.go:52:3: QF1003: could use tagged switch on dependency.ComponentType (staticcheck)
  		if dependency.ComponentType == "connector" {
  		^
  1 issues:
  * staticcheck: 1
  ```

Signed-off-by: Florian Lehner <[email protected]>
rogercoll
rogercoll previously approved these changes Sep 25, 2025
christos68k
christos68k previously approved these changes Sep 25, 2025
Co-authored-by: Christos Kalkanis <[email protected]>
@florianl florianl dismissed stale reviews from christos68k and rogercoll via 6de7aa6 September 25, 2025 11:51
@florianl florianl enabled auto-merge (squash) September 25, 2025 11:51
christos68k
christos68k previously approved these changes Sep 25, 2025
Copy link
Contributor

mergify bot commented Sep 25, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b edot-profiling-docs upstream/edot-profiling-docs
git merge upstream/main
git push upstream edot-profiling-docs

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 26, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR LGTM.

However, I noticed that in #9888 where the profilingreceiver was added, that it's only available on Linux. I wonder if we should add a field to the otelDependency struct to capture which OSes components are available on (defaulting to all OSes, of course). That way we could mention the OS support for each component in the OTel README. This would be done as a follow up PR.

@florianl florianl merged commit 4ddee21 into main Sep 30, 2025
21 checks passed
@florianl florianl deleted the edot-profiling-docs branch September 30, 2025 10:35
Copy link

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @florianl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants