NLog EcsLayout stop using obsolete ConfigurationItemFactory members #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
ConfigurationItemFactory
branch
from
b3b3c65 to
ff3744e
Compare
|
@Mpdreamz Rebased with main, and ready for review |
Mpdreamz
previously approved these changes
Mar 13, 2025
|
@Mpdreamz Any chance for this to be merged, so it can be included in Canary-nuget-release ? (Have NLog v6-Preview1 upcoming) |
snakefoot
force-pushed
the
ConfigurationItemFactory
branch
from
7e9bef0 to
a45b278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLog v5 have marked the
ConfigurationItemFactory-members as obsolete, and they will be removed with NLog v6 (to fix build-warnings about .NET trimming and AOT).This PullRequest will allow the NLog EcsLayout to continue to work, when NLog v6 is released, and users are upgrading.