Skip to content

Conversation

@Samirbous
Copy link
Contributor

@Samirbous Samirbous commented Nov 6, 2025

#5286

Verified cidrmatch on destination.ip works on both integrations (endpoint and sysmon):

destination.ip is of type IP and there is no destination.address of type keyword in sysmon: https://www.elastic.co/docs/reference/integrations/windows#metrics-reference

image

That's the only rule I can see with sysmon and using destination.address https://github.com/search?q=repo%3Aelastic%2Fdetection-rules+destination.address+AND+%22logs-windows.sysmon%22+path%3A%2F%5Erules%5C%2Fwindows%5C%2F%2F&type=code

#5286

Verified cidrmatch on destination.ip works on both integrations (endpoint and sysmon):
@Samirbous Samirbous added bug Something isn't working Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules Integration: Windows labels Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Bug - Guidelines

These guidelines serve as a reminder set of considerations when addressing a bug in the code.

Documentation and Context

  • Provide detailed documentation (description, screenshots, reproducing the bug, etc.) of the bug if not already documented in an issue.
  • Include additional context or details about the problem.
  • Ensure the fix includes necessary updates to the release documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Ensure that the code is modular and reusable where applicable.

Testing

  • New unit tests have been added to cover the bug fix or edge cases.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and detecting the bug fix (e.g., test logs, screenshots).
  • Validate that any rules affected by the bug are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.
  • Conducted system testing, including fleet, import, and create APIs (e.g., run make test-cli, make test-remote-cli, make test-hunting-cli)

Additional Checks

  • Verify that the bug fix works across all relevant environments (e.g., different OS versions).
  • Confirm that the proper version label is applied to the PR patch, minor, major.

@tradebot-elastic
Copy link

tradebot-elastic commented Nov 6, 2025

⛔️ Test failed

Results
  • ❌ Outbound Scheduled Task Activity via PowerShell (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto bug Something isn't working Domain: Endpoint Integration: Windows OS: Windows windows related rules Rule: Tuning tweaking or tuning an existing rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants