Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7dfe056
Add alignment checking for subqueries
eric-forte-elastic Oct 28, 2025
d382c06
add noqa
eric-forte-elastic Oct 28, 2025
4b7e8b4
Update to alpha num
eric-forte-elastic Oct 28, 2025
2e1a738
Add additional format check
eric-forte-elastic Oct 28, 2025
434a0cb
Update to handle multiple exc source formats
eric-forte-elastic Oct 28, 2025
f4b5088
Allow field to be over written with original field
eric-forte-elastic Oct 28, 2025
594f58f
Add comment explaining change
eric-forte-elastic Oct 28, 2025
d83c533
Merge branch 'main' into 5255-bug-dac-auto-gen-schema-fails-on-certai…
eric-forte-elastic Oct 28, 2025
373877c
Adjusted to better match Kibana
eric-forte-elastic Oct 28, 2025
d850951
Merge branch '5255-bug-dac-auto-gen-schema-fails-on-certain-subquerie…
eric-forte-elastic Oct 28, 2025
69eedd0
Fix rule IDs now that we have schema enforcement
eric-forte-elastic Oct 28, 2025
9aedd6d
Update rule prompt to allow for int 0 values
eric-forte-elastic Oct 28, 2025
041b418
Update Audit Beat
eric-forte-elastic Oct 29, 2025
82606e8
Update for correct schema validation
eric-forte-elastic Oct 29, 2025
1cc060c
revert email change
eric-forte-elastic Oct 29, 2025
85fcbc9
Add email action connector
eric-forte-elastic Oct 29, 2025
6583002
Update Non ECS Combined Mappings
eric-forte-elastic Nov 6, 2025
8277147
Merge branch 'main' into 5255-bug-dac-auto-gen-schema-fails-on-certai…
shashank-elastic Nov 11, 2025
11deb3a
Update detection_rules/rule_validators.py
eric-forte-elastic Nov 11, 2025
356eda9
fix typo
eric-forte-elastic Nov 11, 2025
3eb3540
Merge branch '5255-bug-dac-auto-gen-schema-fails-on-certain-subquerie…
eric-forte-elastic Nov 11, 2025
b8df2ac
Handle custom schema overwrites
eric-forte-elastic Nov 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions detection_rules/cli_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ def _convert_type(_val: Any) -> Any:
)

while True:
result = value or input(prompt) or default
result = value if value is not None else input(prompt) or default
if result == "n/a":
result = None

if not result:
if result is None:
if is_required:
value = None
continue
Expand Down Expand Up @@ -318,7 +318,7 @@ def rule_prompt( # noqa: PLR0912, PLR0913, PLR0915
contents[name] = threat_map
continue

if kwargs.get(name):
if name in kwargs:
contents[name] = schema_prompt(name, value=kwargs.pop(name))
continue

Expand Down
Loading
Loading