[Bug] Point test_schemas ES|QL to tests/data #5127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17cell
requested review from
Mikaayenson,
eric-forte-elastic and
traut
as code owners
|
💚 CLA has been signed |
|
Thanks @17cell for opening the PR. Can you sign the CLA and add a version bump to pyproject.toml ? |
|
Thanks for the review @Mikaayenson I have bumped the version and signed the CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
After discussing with @eric-forte-elastic , we decided to configure ES|QL schema validation to reference tests/data/{place-holder}.toml for flexibility, rather than hardcoding a rule in the rules/ directory that might be decommissioned
Summary - What I changed
I cloned the ES|QL rule rules/windows/defense_evasion_posh_obfuscation_index_reversal.toml into tests/data and pointed the rule_path in test_schemas.py to the tests/data directory.
How To Test
python3.12 -m detection_rules test