Add Primary Buildkite Pipeline Migration #571
Conversation
markjhoy
changed the title
There was a problem hiding this comment.
looks good, in addition to a couple nits, just a few questions:
- the jenkins pipeline appears to do some artifact archiving here; we don't need that any longer?
- also looks like maybe we had slack notifications setup (although not 100% sure they were enabled); confirming we no longer need this?
.buildkite/pipeline.yml
Outdated
| - "./.buildkite/scripts/run_command.sh tests" | ||
| artifact_paths: | ||
| - "coverage/index.html" | ||
| - label: ":wrench: Linter" | ||
| commands: | ||
| - "./.buildkite/scripts/run_command.sh linter" | ||
| - label: ":package: Docker" | ||
| commands: | ||
| - "./.buildkite/scripts/run_command.sh docker" | ||
| - label: ":package: Packaging" | ||
| commands: | ||
| - "./.buildkite/scripts/run_command.sh packaging" |
There was a problem hiding this comment.
nit: are the leading ./s needed here?
There was a problem hiding this comment.
I don't think so... fixing...
.buildkite/pipeline.yml
Outdated
| agents: | ||
| provider: "gcp" | ||
| machineType: "n1-standard-8" | ||
| useVault: true |
There was a problem hiding this comment.
just checking: do we need this? not immediately seeing where we need a Vault token in this pipeline
There was a problem hiding this comment.
Good call - let's find out ;) incoming commit
The
This will be enabled automagically once this gets into |
oh nice, totally missed that, thank you!
awesome! |
💔 Failed to create backport PR(s)
To backport manually run: |
💔 Failed to create backport PR(s)
To backport manually run: |
* add primary pipeline migration * remove leading ./ ; remove useVault (cherry picked from commit a393128) # Conflicts: # .buildkite/pipeline.yml
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* Add Primary Buildkite Pipeline Migration (#571) * add primary pipeline migration * remove leading ./ ; remove useVault (cherry picked from commit a393128) # Conflicts: # .buildkite/pipeline.yml * Remove not needed CI steps --------- Co-authored-by: Mark J. Hoy <[email protected]>
Migrates the primary pipeline from Jenkins to Buildkite
Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)