-
Notifications
You must be signed in to change notification settings - Fork 5k
[libbeat] Input reload: do not log error at debug level if error is nil #47422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 GitHub commentsJust comment with:
|
Collaborator
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
mauri870
approved these changes
Nov 3, 2025
khushijain21
approved these changes
Nov 4, 2025
Contributor
|
@Mergifyio backport 8.19 9.1 9.2 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
(cherry picked from commit 9c4239e)
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
(cherry picked from commit 9c4239e)
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
(cherry picked from commit 9c4239e) # Conflicts: # libbeat/cfgfile/reload.go
This was referenced Nov 4, 2025
belimawr
added a commit
that referenced
this pull request
Nov 4, 2025
…7451) (cherry picked from commit 9c4239e) Co-authored-by: Tiago Queiroz <[email protected]>
belimawr
added a commit
that referenced
this pull request
Nov 4, 2025
…7452) (cherry picked from commit 9c4239e) Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-active-all
Automated backport with mergify to all the active branches
skip-changelog
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works. Where relevant, I have used thestresstest.shscript to run them under stress conditions and race detector to verify their stability.I have added an entry in./changelog/fragmentsusing the changelog tool.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
1. Create the following
filebeat.yaml2. Create the following
inputs.d/filestream.ymlStart Filebeat and ensure the following debug log level message does not appear
{ "@timestamp": "2025-10-31T20:20:32.171-0400", "ecs.version": "1.6.0", "log.level": "debug", "log.logger": "crawler.input.reloader", "log.origin": { "file.line": 231, "file.name": "cfgfile/reload.go", "function": "github.com/elastic/beats/v7/libbeat/cfgfile.(*Reloader).Run" }, "message": "error '<nil>' cannot retried. Modify any input file to reload.", "service.name": "filebeat" }## Related issues## Use cases## Screenshots## Logs