Skip to content

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented Oct 31, 2025

Proposed commit message

see title

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

1. Create the following filebeat.yaml

filebeat.config:
  inputs:
    enabled: true
    path: inputs.d/*.yml
    reload.enabled: true
    reload.period: 5s

output.discard:
  enabled: true

logging:
  to_stderr: true
  level: debug
  selectors:
    - "*"

2. Create the following inputs.d/filestream.yml

- type: filestream
  id: foo
  paths:
    - /tmp/flog.log

Start Filebeat and ensure the following debug log level message does not appear

{
  "@timestamp": "2025-10-31T20:20:32.171-0400",
  "ecs.version": "1.6.0",
  "log.level": "debug",
  "log.logger": "crawler.input.reloader",
  "log.origin": {
    "file.line": 231,
    "file.name": "cfgfile/reload.go",
    "function": "github.com/elastic/beats/v7/libbeat/cfgfile.(*Reloader).Run"
  },
  "message": "error '<nil>' cannot retried. Modify any input file to reload.",
  "service.name": "filebeat"
}

## Related issues
## Use cases
## Screenshots
## Logs

@belimawr belimawr self-assigned this Oct 31, 2025
@belimawr belimawr added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-active-all Automated backport with mergify to all the active branches skip-changelog labels Oct 31, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 31, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@belimawr belimawr marked this pull request as ready for review November 1, 2025 00:21
@belimawr belimawr requested a review from a team as a code owner November 1, 2025 00:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@belimawr belimawr changed the title [libbeat] Input reload: do not log error if error is nil [libbeat] Input reload: do not log error at debug level if error is nil Nov 1, 2025
@belimawr belimawr merged commit 9c4239e into elastic:main Nov 4, 2025
219 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

@Mergifyio backport 8.19 9.1 9.2

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants