systemtest/gencorpora: generate corpus metadata #8937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
lahsivjar
force-pushed
the
8754_run-rally
branch
from
8ecaf8f to
23f64c4
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
lahsivjar
force-pushed
the
8754_run-rally
branch
from
23f64c4 to
272d911
Compare
📚 Go benchmark reportDiff with the report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
axw
reviewed
Aug 23, 2022
kruskall
reviewed
Aug 23, 2022
systemtest/gencorpora/catbulk.go
Outdated
| for count := 0; scanner.Scan(); count++ { | ||
| fmt.Fprintln(writer, scanner.Text()) | ||
| if _, err := fmt.Fprintln(&buf, scanner.Text()); err != nil { |
There was a problem hiding this comment.
Suggested change
| if _, err := fmt.Fprintln(&buf, scanner.Text()); err != nil { | |
| if _, err := buf.Write(scanner.Bytes()); err != nil { |
suggestion: I think we can avoid a byte->string conversion and use the buffer directly. WDYT ?
There was a problem hiding this comment.
This will not work since the bulk API requires newline delimited JSON and scanner strips EOL markers. However, it is possible to optimize performance here by customizing the scanner -- I was being lazy here since it is not in the critical code path. Let me update this.
|
I have updated the code to split input expecting NDJSON doc with metadata followed by source. This should cleanup the code a bit and have less memory footprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
A
corporais required for defining the rally track. The corpora schema requires a list of document files and each document has the following requirements:document-countandsource-fileare mandatorycompressed-bytesanduncompressed-bytesis recommendedThis PR adds support to generate the document file with the above fields (other than
compressed-bytes).Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackagehave been made)- [ ] Documentation has been updatedHow to test these changes
N/A
Related issues
Part of: #8754