-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog for APM Server monitoring fixes #15561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed - this PR should work as intended to update the changelog on the website, but is there a reason to not backport the PR to 8.18 and 8.x branch? (and possibly 9.0?) They also have 8.16.asciidoc and 8.17.asciidoc and they should be consistent (and identical) across branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, backporting a 8.17.asciidoc change to 8.16 branch will cause a merge conflict but that can be resolved easily. It should be fine. Alternatively, the 8.16.asciidoc and 8.17.asciidoc change can be separated into 2 PRs.
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b)
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) # Conflicts: # changelogs/8.17.asciidoc
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) # Conflicts: # changelogs/8.16.asciidoc
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b)
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b)
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) Co-authored-by: Edoardo Tenani <[email protected]>
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b)
…15650) * changelog for APM Server monitoring fixes (#15561) * backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) # Conflicts: # changelogs/8.17.asciidoc * changelog: remove 8.17 log entry --------- Co-authored-by: Edoardo Tenani <[email protected]> Co-authored-by: Kostiantyn Masliuk <[email protected]>
…15651) * changelog for APM Server monitoring fixes (#15561) * backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) # Conflicts: # changelogs/8.16.asciidoc * changelog: revert 8.16 log --------- Co-authored-by: Edoardo Tenani <[email protected]> Co-authored-by: Kostiantyn Masliuk <[email protected]>
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) Co-authored-by: Edoardo Tenani <[email protected]>
* backport change to 8.17.2 changelog * backport change to 8.16.4 changelog * Update 8.16.asciidoc --------- Co-authored-by: Kostiantyn Masliuk <[email protected]> (cherry picked from commit 6c9108b) Co-authored-by: Edoardo Tenani <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Motivation/summary
Changes have been backported to 8.16.4 and 8.17.2 that require a changelog entry.
See #14247 (comment).
Checklist
How to test these changes
Related issues
#14247