Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TBS: fix log formatting #15496

Merged
merged 2 commits into from
Jan 31, 2025
Merged

TBS: fix log formatting #15496

merged 2 commits into from
Jan 31, 2025

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jan 30, 2025 •
edited
Loading

Motivation/summary

Fix a missing colon in logs (typo from #15235 ), and remove "storage" in "configured storage limit reached" message to make way for #15467 to avoid confusion

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner January 30, 2025 23:54
@carsonip carsonip added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Jan 30, 2025
@carsonip carsonip enabled auto-merge (squash) January 31, 2025 11:04
@carsonip carsonip merged commit 28068bd into elastic:main Jan 31, 2025
12 checks passed
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@carsonip @mergify
TBS: fix log formatting (#15496)
3d8617b 
Fix a missing colon in logs (typo from #15235 ), and remove "storage" in "configured storage limit reached" message to make way for #15467 to avoid confusion

(cherry picked from commit 28068bd)
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@carsonip @mergify
TBS: fix log formatting (#15496)
a128ebb 
Fix a missing colon in logs (typo from #15235 ), and remove "storage" in "configured storage limit reached" message to make way for #15467 to avoid confusion

(cherry picked from commit 28068bd)

# Conflicts:
#	x-pack/apm-server/sampling/eventstorage/rw.go
This was referenced Jan 31, 2025
Closed
Merged
mergify bot added a commit that referenced this pull request Jan 31, 2025
@mergify @carsonip
TBS: fix log formatting (#15496) (#15499)
435ae69 
Fix a missing colon in logs (typo from #15235 ), and remove "storage" in "configured storage limit reached" message to make way for #15467 to avoid confusion

(cherry picked from commit 28068bd)

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonip @axw