-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Translate otel metrics to libbeat monitoring (backport #15094) #15440
Conversation
* Translate otel metrics to libbeat monitoring * demo: send metrics directly and add another reader * Revert "demo: send metrics directly and add another reader" This reverts commit 166a717. * lint: fix linter issues * lint: fix linter issues * feat: refactor code to propagate meterprovider and fix tests * lint: fix linter issues * refactor: remove unused files * refactor: remove more global meters * refactor: cleanup more unused code * refactor: remove more unused code * test: account for agentcfg metric in test * test: account for agentcfg metric in test * fix: pass meter provider in main func * Fix LSM metrics tests * test: fix remaining test * lint: fix linter issues * fix: update docappender metrics name * test: update systemtest metric assertions * fix: update grpc interceptor meter path metrics were not being exported because the meter was not recognized as apm-server meter * fix: add back output.type=elasticsearch * test: upate remaining systemtest * test: remove debug print * fix: use correct outputRegistry variable fix panic * fix: remove panic on err * fix: propagate meter provider to grpc services * lint: add meterprovider field docs * lint: fix comment typo * feat: pass apmotel gatherer too * refactor: use switch pattern consistently when mapping metrics * Update beater.go * Update beat.go * Update beater.go * fix: solve compile errors and systemtest fix * refactor: reduce diff noise * lint: fix linter issues * lint: fix linter issues * Update x-pack/apm-server/main.go Co-authored-by: Andrew Wilkins <[email protected]> * test: use legacy metrics for validating grpc tests * fix: unregister callback if available forgot to pus this --------- Co-authored-by: Andrew Wilkins <[email protected]> Co-authored-by: Andrew Wilkins <[email protected]> (cherry picked from commit 378b60c) # Conflicts: # internal/beatcmd/beat.go # internal/beater/beater.go # internal/beater/server.go # internal/beater/server_test.go
Cherry-pick of 378b60c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@kruskall why is this closed? Is it because we do not intend to backport this to 8.x? |
This pull request is now in conflicts. Could you fix it @mergify[bot]? 🙏
|
Motivation/summary
use otel api to record metrics and export them to beats monitoring
Checklist
For functional changes, consider:
How to test these changes
Related issues
Related to #14488
This is an automatic backport of pull request #15094 done by [Mergify](https://mergify.com).