-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation: fix log trace inconsistent status code with error result chaining #15122
Conversation
This pull request does not have a backport label. Could you fix it @1pkg? 🙏
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this looks like an overkill which further complicates a part that is already failing due to its complexity. Let's work on #15123
I agree, that this approach introduces too much complexity for a little benefit. |
Closing this in favor of simple timeout check version from #15123 |
Motivation/summary
This fix is branched from #15117.
This PR introduces additional error
request.Result
chaining for secondary errors that can happen after the response has already been written e.g. timeout or panic. The rationale behind this change to create an ability to pass multiple errors in the result object so they could be eventually logged while maintaining original response.As a result of this changes self instrumentation transaction will always contain original error, while logging middleware will log both the original error and the secondary timeout error.
This is alternative to errors chaining PR #15123 which will use single error depending on when timeout happened.
Checklist
For functional changes, consider:
How to test these changes
Related issues
#15123
#15117
#14232