[8.x] fix: clear scroll after completing scroll requests (backport #14551) #14631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: clear scroll after completing scroll requests clear the search context using a clear scroll request for sourcemap and agentcfg search scroll requests * lint: fix linter issues * fix: clear scroll on error too * test: validate scrollID when clearing * test: increase sourcemap test coverage to use scroll requests * feat: log failed clear scroll requests * Update elasticsearch.go * Update metadata_fetcher.go (cherry picked from commit 9487f8d)
kruskall
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
clear the search context using a clear scroll request for sourcemap and agentcfg search scroll requests
Checklist
For functional changes, consider:
How to test these changes
Related issues
Related to #14619
This is an automatic backport of pull request #14551 done by [Mergify](https://mergify.com).