Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] ci(benchmarks): read secrets for running the tear-down immediately after (backport #14323) #14333

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 10, 2024

Motivation/summary

Trying to solve 'partially' the below error:

api error: root.unauthenticated: The supplied authentication is invalid

The benchmarks ran, but the API token was rotated during the execution. This can help with refreshing it since benchmarks can take 4 hours or so... so we don't know if the secret is rotated meanwhile.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #14323 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 10, 2024 15:11
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 10, 2024
@mergify mergify bot assigned v1v Oct 10, 2024
Copy link
Contributor Author

mergify bot commented Oct 10, 2024

Cherry-pick of f5dcbf8 has failed:

On branch mergify/bp/8.x/pr-14323
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit f5dcbf870.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/smoke-tests-ess.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/benchmarks.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@v1v v1v removed the conflicts There is a conflict in the backported pull request label Oct 10, 2024
@v1v v1v enabled auto-merge (squash) October 10, 2024 15:42
Copy link
Contributor Author

mergify bot commented Oct 11, 2024

This pull request is now in conflicts. Could you fix it @mergify[bot]? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-14323 upstream/mergify/bp/8.x/pr-14323
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-14323

@1pkg 1pkg force-pushed the mergify/bp/8.x/pr-14323 branch from 166cd63 to 6e2b16d Compare October 11, 2024 16:25
@1pkg 1pkg disabled auto-merge October 11, 2024 16:26
@1pkg
Copy link
Member

1pkg commented Oct 11, 2024

Similar to backport from #14336, merged missing CI backport and rebased this branch. The CI conflicts should no longer appear now.

@mergify mergify bot merged commit 7d7a907 into 8.x Oct 11, 2024
13 checks passed
@mergify mergify bot deleted the mergify/bp/8.x/pr-14323 branch October 11, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants