-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sending local collection metrics to batch processor #12228
Disable sending local collection metrics to batch processor #12228
Conversation
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meterProvider := metric.NewMeterProvider( | ||
metric.WithReader(exporter), | ||
metric.WithReader(metric.NewPeriodicReader(localExporter)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need this for the otel metrics. Added in #11470
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought metric.WithReader(exporter),
is good enough for otel. localExporter
is for exporting to the batchprocessor interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first reader should be enough for otel, yes.
meterProvider := metric.NewMeterProvider( | ||
metric.WithReader(exporter), | ||
metric.WithReader(metric.NewPeriodicReader(localExporter)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first reader should be enough for otel, yes.
Remove localExporter so that default instrumentation metrics are not sent to `metrics-apm.app.apm-server-*` (cherry picked from commit 9da279f)
…12491) Remove localExporter so that default instrumentation metrics are not sent to `metrics-apm.app.apm-server-*` (cherry picked from commit 9da279f) Co-authored-by: Carson Ip <[email protected]>
Testing notes✔️ test-plan-ok 8.12.0Dev tools:
returns Details```json { "took": 20, "timed_out": false, "_shards": { "total": 1, "successful": 1, "skipped": 0, "failed": 0 }, "hits": { "total": { "value": 10000, "relation": "gte" }, "max_score": 1, "hits": [ { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "ptEQfo0BV9mN7pGUT0y7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:56:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:56:54Z", "received": "2024-02-06T10:56:53.712Z" }, "http": { "server": { "request": { "count": 12 } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "p9EQfo0BV9mN7pGUT0y7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:56:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:56:54Z", "received": "2024-02-06T10:56:53.712Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "qNEQfo0BV9mN7pGUT0y7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:56:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:56:54Z", "received": "2024-02-06T10:56:53.712Z" }, "http": { "server": { "response": { "valid": { "count": 12 } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "oNEOfo0BV9mN7pGUekz8", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:54:53.713Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:54:54Z", "received": "2024-02-06T10:54:53.713Z" }, "http": { "server": { "request": { "count": 12 } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "odEOfo0BV9mN7pGUekz8", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:54:53.713Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:54:54Z", "received": "2024-02-06T10:54:53.713Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "otEOfo0BV9mN7pGUekz8", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:54:53.713Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:54:54Z", "received": "2024-02-06T10:54:53.713Z" }, "http": { "server": { "response": { "valid": { "count": 12 } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "o9EPfo0BV9mN7pGUZUxc", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:55:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:55:54Z", "received": "2024-02-06T10:55:53.712Z" }, "http": { "server": { "request": { "count": 12 } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "pNEPfo0BV9mN7pGUZUxc", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:55:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:55:54Z", "received": "2024-02-06T10:55:53.712Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "pdEPfo0BV9mN7pGUZUxc", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:55:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:55:54Z", "received": "2024-02-06T10:55:53.712Z" }, "http": { "server": { "response": { "valid": { "count": 12 } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "mtEMfo0BV9mN7pGUpkw7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:52:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:52:54Z", "received": "2024-02-06T10:52:53.712Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } } ] } } ``` 8.12.1Dev tools:
returns {
"took": 0,
"timed_out": false,
"_shards": {
"total": 0,
"successful": 0,
"skipped": 0,
"failed": 0
},
"hits": {
"total": {
"value": 0,
"relation": "eq"
},
"max_score": 0,
"hits": []
}
} |
Motivation/summary
Disable default instrumentation metrics sending to batch processor by removing local exporter.
Checklist
For functional changes, consider:
How to test these changes
Ensure that no
metrics-apm.app.apm_server-*
is automatically created when apm-server runs.Related issues
Closes #12225