Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sending local collection metrics to batch processor #12228

Merged
merged 8 commits into from
Jan 23, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Dec 14, 2023

Motivation/summary

Disable default instrumentation metrics sending to batch processor by removing local exporter.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Ensure that no metrics-apm.app.apm_server-* is automatically created when apm-server runs.

Related issues

Closes #12225

Copy link
Contributor

mergify bot commented Dec 14, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 14, 2023
@carsonip carsonip added backport-8.12 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Dec 14, 2023
@carsonip carsonip requested a review from simitt December 14, 2023 16:39
@carsonip carsonip marked this pull request as ready for review January 18, 2024 15:48
@carsonip carsonip requested a review from a team as a code owner January 18, 2024 15:48
Copy link
Member Author

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meterProvider := metric.NewMeterProvider(
metric.WithReader(exporter),
metric.WithReader(metric.NewPeriodicReader(localExporter)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this for the otel metrics. Added in #11470

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought metric.WithReader(exporter), is good enough for otel. localExporter is for exporting to the batchprocessor interface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first reader should be enough for otel, yes.

@carsonip carsonip requested a review from dmathieu January 23, 2024 13:08
meterProvider := metric.NewMeterProvider(
metric.WithReader(exporter),
metric.WithReader(metric.NewPeriodicReader(localExporter)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first reader should be enough for otel, yes.

@carsonip carsonip requested a review from kruskall January 23, 2024 15:56
@carsonip carsonip enabled auto-merge (squash) January 23, 2024 17:20
@carsonip carsonip merged commit 9da279f into elastic:main Jan 23, 2024
10 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2024
Remove localExporter so that default instrumentation metrics are not sent to `metrics-apm.app.apm-server-*`

(cherry picked from commit 9da279f)
mergify bot added a commit that referenced this pull request Jan 23, 2024
…12491)

Remove localExporter so that default instrumentation metrics are not sent to `metrics-apm.app.apm-server-*`

(cherry picked from commit 9da279f)

Co-authored-by: Carson Ip <[email protected]>
@carsonip
Copy link
Member Author

carsonip commented Feb 6, 2024

Testing notes

✔️ test-plan-ok
local collection metrics are no longer available on 8.12.1

8.12.0

Dev tools:

GET /metrics-apm.app.apm_server-*/_search

returns

Details

```json { "took": 20, "timed_out": false, "_shards": { "total": 1, "successful": 1, "skipped": 0, "failed": 0 }, "hits": { "total": { "value": 10000, "relation": "gte" }, "max_score": 1, "hits": [ { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "ptEQfo0BV9mN7pGUT0y7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:56:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:56:54Z", "received": "2024-02-06T10:56:53.712Z" }, "http": { "server": { "request": { "count": 12 } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "p9EQfo0BV9mN7pGUT0y7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:56:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:56:54Z", "received": "2024-02-06T10:56:53.712Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "qNEQfo0BV9mN7pGUT0y7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:56:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:56:54Z", "received": "2024-02-06T10:56:53.712Z" }, "http": { "server": { "response": { "valid": { "count": 12 } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "oNEOfo0BV9mN7pGUekz8", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:54:53.713Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:54:54Z", "received": "2024-02-06T10:54:53.713Z" }, "http": { "server": { "request": { "count": 12 } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "odEOfo0BV9mN7pGUekz8", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:54:53.713Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:54:54Z", "received": "2024-02-06T10:54:53.713Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "otEOfo0BV9mN7pGUekz8", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:54:53.713Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:54:54Z", "received": "2024-02-06T10:54:53.713Z" }, "http": { "server": { "response": { "valid": { "count": 12 } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "o9EPfo0BV9mN7pGUZUxc", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:55:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:55:54Z", "received": "2024-02-06T10:55:53.712Z" }, "http": { "server": { "request": { "count": 12 } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "pNEPfo0BV9mN7pGUZUxc", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:55:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:55:54Z", "received": "2024-02-06T10:55:53.712Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "pdEPfo0BV9mN7pGUZUxc", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:55:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:55:54Z", "received": "2024-02-06T10:55:53.712Z" }, "http": { "server": { "response": { "valid": { "count": 12 } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } }, { "_index": ".ds-metrics-apm.app.apm_server-default-2024.02.01-000001", "_id": "mtEMfo0BV9mN7pGUpkw7", "_score": 1, "_source": { "@timestamp": "2024-02-06T10:52:53.712Z", "data_stream": { "dataset": "apm.app.apm_server", "namespace": "default", "type": "metrics" }, "event": { "agent_id_status": "missing", "ingested": "2024-02-06T10:52:54Z", "received": "2024-02-06T10:52:53.712Z" }, "http": { "server": { "request": { "duration": { "values": [ 0.001953125 ], "counts": [ 12 ] } } } }, "metricset": { "name": "app" }, "observer": { "hostname": "54dd7c335acb", "type": "apm-server", "version": "8.12.0" }, "processor": { "event": "metric" }, "service": { "language": { "name": "go" }, "name": "apm-server" } } } ] } } ```

8.12.1

Dev tools:

GET /metrics-apm.app.apm_server-*/_search

returns

{
  "took": 0,
  "timed_out": false,
  "_shards": {
    "total": 0,
    "successful": 0,
    "skipped": 0,
    "failed": 0
  },
  "hits": {
    "total": {
      "value": 0,
      "relation": "eq"
    },
    "max_score": 0,
    "hits": []
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable default metrics collection from apm-server
3 participants