Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][OTel] Fix link to hostmetrics receiver #12207

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ycombinator
Copy link
Contributor

Motivation/summary

While reading through https://www.elastic.co/guide/en/apm/guide/current/open-telemetry-direct.html#connect-open-telemetry-collector, I noticed that the link to the hostmetrics receiver was broken. This is likely due to the fact that the hostmetrics receiver was part of the vanilla OTel Collector distribution up through v0.33.0 but was then moved to the opentelemetry-collector-contrib repository.

This PR updates the link for the hostmetrics receiver to point to its new location, in the opentelemetry-collector-contrib repository.

Checklist

  • Documentation has been updated

@ycombinator ycombinator requested a review from a team as a code owner December 12, 2023 19:50
Copy link
Contributor

mergify bot commented Dec 12, 2023

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 12, 2023
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@axw
Copy link
Member

axw commented Dec 13, 2023

@ycombinator can you please sign your commit? Or I can recreate it if that's a pain.

@ycombinator ycombinator force-pushed the docs-otel-fix-hostmetrics-link branch from 4cc0aaa to 8ff8d27 Compare December 13, 2023 06:46
@ycombinator
Copy link
Contributor Author

@ycombinator can you please sign your commit? Or I can recreate it if that's a pain.

Done.

@axw axw merged commit f261e01 into elastic:main Dec 13, 2023
5 checks passed
@axw axw added backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Dec 13, 2023
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
@ycombinator ycombinator deleted the docs-otel-fix-hostmetrics-link branch December 13, 2023 13:04
mergify bot added a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit f261e01)

Co-authored-by: Shaunak Kashyap <[email protected]>
mergify bot added a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit f261e01)

Co-authored-by: Shaunak Kashyap <[email protected]>
mergify bot added a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit f261e01)

Co-authored-by: Shaunak Kashyap <[email protected]>
mergify bot added a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit f261e01)

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit f261e01)

Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants