Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove check-docker-compose task #12206

Closed
wants to merge 1 commit into from

Conversation

kruskall
Copy link
Member

Motivation/summary

docker compose is only used for system tests and we are automation to bump the version. This means there is nothing actionable on our end and it might cause CI to fail if the ES/Kibana docker image is not available.

This is currently the case for the 8.13.0 SNAPSHOT version.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

docker compose is only used for system tests and we are automation to bump the version.
This means there is nothing actionable on our end and it might cause CI to fail if the
ES/Kibana docker image is not available.
@kruskall kruskall requested a review from a team as a code owner December 12, 2023 15:49
@kruskall kruskall added backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify labels Dec 12, 2023
@kruskall kruskall enabled auto-merge (squash) December 12, 2023 16:07
@kruskall kruskall disabled auto-merge December 12, 2023 16:07
@kruskall kruskall marked this pull request as draft December 21, 2023 16:42
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

mergify bot commented Jan 16, 2024

This pull request is now in conflicts. Could you fix it @kruskall? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ci/drop-compose-check upstream/ci/drop-compose-check
git merge upstream/main
git push upstream ci/drop-compose-check

1 similar comment
Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request is now in conflicts. Could you fix it @kruskall? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ci/drop-compose-check upstream/ci/drop-compose-check
git merge upstream/main
git push upstream ci/drop-compose-check

@v1v
Copy link
Member

v1v commented Feb 9, 2024

run docs-build

@kruskall
Copy link
Member Author

Superseded by #12637

@kruskall kruskall closed this Feb 13, 2024
@kruskall kruskall deleted the ci/drop-compose-check branch February 13, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants