Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cpuprofile arg support to benchmark make task #12073

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

kruskall
Copy link
Member

Motivation/summary

Add BENCHMARK_CPU_OUT variable and pass cpuprofile arg to apmbench.

This PR allows creating cpu profile when running benchmark to investigate performance issues.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  1. BENCHMARK_CPU_OUT=cpu.out make run-benchmark
  2. BENCHMARK_CPU_OUT=cpu.out make cp-cpuprof
  3. open cpu.out file locally

Related issues

@kruskall kruskall requested a review from a team as a code owner November 17, 2023 20:31
Copy link
Contributor

mergify bot commented Nov 17, 2023

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 17, 2023
@v1v
Copy link
Member

v1v commented Feb 9, 2024

run docs-build

@kruskall kruskall enabled auto-merge (squash) March 28, 2024 11:39
@kruskall kruskall merged commit 4c59f13 into elastic:main Mar 28, 2024
8 checks passed
@kruskall kruskall deleted the feat/bench-cpuprof branch April 15, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants