Speed up builds with less sleeps steps

[v1v]

What does this PR do?

Try/Catch errors and retry with a sleep.

Why is it important?

It will speed up the CI builds as the sleep doesn't happen firstly but only if there are failures.
The sleep was in place to ensure DDOS attack is not detected when running a bunch of parallel stages to interact with our systems, such as docker.registry and vault.

Related issues

This could be implemented with the proposal in jenkinsci/workflow-basic-steps-plugin#97

How to test this

$ hub pr checkout 376
$ cd local
$ make build
$ make start
$ cd workers/linux
$ vagrant up --provision
$ open http://localhost:18080/job/it/job/gitCheckout/
$ open http://localhost:18080/job/it/job/withTotpVault/
$ open http://localhost:18080/job/it/job/gitBaseCommit/job/master/
## build the above pipelines a few times (the first time might take a bit longer as it does require to syncup the shared library)

Tests

• Vault access
  From 12 seconds average to 2 seconds

• Checkout in pipelines

From 30 seconds average to 18 seconds

• Checkout in multibranch pipelines

From 1min and 40 seconds average to 24 seconds

[v1v]

increased the number of retries a shorter sleep

[v1v]

Sleep only if it fails, then let's honor those steps that don't have a timeout issue

[v1v]

Unrequired error, throw err is the one in charge.

[ghost]

💚 Build Succeeded

• pipeline
• Commit: 60a8d35

[kuisathaverat]

I see a new step in the horizon 😄

sleepOnError(min: 0, max:30){
  echo "I am a command"
}

def call(Map params = [:], Closure body) {
  def min = params.containsKey('min') ? params.min : 0
  def max = params.containsKey('max') ? params.max : 30
  try{
    body()
  } catch (e){
    sleep randomNumber(min: min, max: max)
    throw e
  }
}

[v1v]

That's a good point, I actually was thinking to provide that step as a built-in step in the declarative pipeline:

retry(times: 3, sleep: 5)

[v1v]

jenkinsci/workflow-basic-steps-plugin#97 is the one for that particular requirement :)

[ghost]

💚 Build Succeeded

• pipeline
• Commit: 1a8ff65